feat(formatting): format generated diff corrections - #16209
Open
rgrinberg wants to merge 1 commit into
Open
Conversation
rgrinberg
force-pushed
the
push-ywrznspwmqkx
branch
8 times, most recently
from
August 28, 2026 15:47
965a344 to
380f74d
Compare
Starting with Dune 3.25, format generated corrections consumed by optional text diffs before comparing or promoting them. Select Dune's built-in formatter or OCamlFormat according to the source's formatting configuration, and use the locked OCamlFormat dev tool when available. Construct formatted diffs directly during action expansion so formatter dependencies, environments, and sandbox requirements remain attached to the action. Apply the behavior to user diff? actions and Cinaps without exposing generated corrections as separate build targets. Projects using older language versions retain the previous behavior. Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
rgrinberg
force-pushed
the
push-ywrznspwmqkx
branch
from
August 30, 2026 16:21
380f74d to
8a50b27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting with Dune 3.25, format generated corrections consumed by optional text
diffs before they are compared or promoted. Select Dune's built-in formatter
or OCamlFormat according to the source's formatting configuration, including
the locked OCamlFormat dev tool when available.
Apply this to user
diff?actions and Cinaps without exposing generatedcorrections as separate build targets. Construct formatted diffs directly during
action expansion so formatter dependencies, environments, and sandbox
requirements remain attached to the action. Older language versions retain the
previous behavior.